Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instagram] Don't check private status for *.../YOU/following* #5322

Conversation

tinnet
Copy link
Contributor

@tinnet tinnet commented Mar 12, 2024

When grabbing https://www.instagram.com/YOU/following we don't need to check/back off if YOU is a private account.

When grabbing *.../your_own_user/following* we don't need to check if
*your_own_user* is a private account.
@mikf
Copy link
Owner

mikf commented Mar 12, 2024

This check is not necessary for your own account, but it probably is for all other accounts unless it is somehow possible to access followed users of private accounts.

I don't think there's a way to check whether the current user is your own, so I've just changed this error message from an exception to a simple warning, which kind of does the same as your change. (dde822e)

@mikf mikf closed this Mar 12, 2024
@tinnet
Copy link
Contributor Author

tinnet commented Mar 12, 2024

This check is not necessary for your own account, but it probably is for all other accounts unless it is somehow possible to access followed users of private accounts.

oh yeah my scenario is downloading what i follow while logged in for e.g. a telegram bot or something

I don't think there's a way to check whether the current user is your own, so I've just changed this error message from an exception to a simple warning, which kind of does the same as your change. (dde822e)

not sure it's the same, i only disabled the check for the first uid retrieval, not inside the loop of all followed accounts.
what's the point of having a warning logged? i assumed the original exception was to avoid instagram getting angry and banning?
i didn't go back in the commit history to check why it was added, i just saw the override and thought this was an appropriate place to use it

but either way 👍

@tinnet tinnet deleted the fix/dont-check-private-on-self-for-following branch March 18, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants