optimize _find_most_recently_used_file for exact profile #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading cookies from the browser, the user is able to give either just the browser name, or also provide profile/container information. If an exact profile is provided, there is no need to find the latest profile with `os.walk` which is very expensive. This change optimizes that case and the performance increase is significant (~8 sec to 0.6 sec). ``` $ time gallery-dl --config-ignore -d . -D . --cookies-from-browser FIREFOX https://imgur.com/OO4UNqJ [cookies][info] Extracted 16 cookies from Firefox ./imgur_OO4UNqJ.jpg real 0m8.429s user 0m0.216s sys 0m0.431s $ time gallery-dl --config-ignore -d . -D . --cookies-from-browser FIREFOX:bgamf5r6.default-release https://imgur.com/OO4UNqJ [cookies][info] Extracted 16 cookies from Firefox ./imgur_OO4UNqJ.jpg real 0m0.456s user 0m0.183s sys 0m0.011s $ gallery-dl --version 1.26.9 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading cookies from the browser, the user is able to give either just the browser name, or also provide profile/container information.
If an exact profile is provided, there is no need to find the latest profile with
os.walkwhich is very expensive.This change optimizes that case and the performance increase is significant (~8 sec to 0.6 sec).