Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update redgifs.py to include 0-9 regex, fixes #5898 #5899

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Update redgifs.py to include 0-9 regex, fixes #5898 #5899

merged 1 commit into from
Jul 28, 2024

Conversation

reasonabledoubt
Copy link
Contributor

Update redgifs.py to include 0-9 regex, fixes #5898

First pull request to this repo, willing to accept any criticism/input/etc.

Thanks!

mikf added a commit that referenced this pull request Jul 28, 2024
@mikf
merge #5899: [redgifs] support URLs with numeric IDs (#5898)
65d7ccc
@mikf mikf merged commit f8a7a61 into mikf:master Jul 28, 2024
9 checks passed
@mikf
Copy link
Owner

mikf commented Jul 28, 2024

Thanks

willing to accept any criticism/input/etc.

It didn't really matter here, but you should ideally open PRs from a separate branch and not from master/main.

@reasonabledoubt
Copy link
Contributor Author

It didn't really matter here, but you should ideally open PRs from a separate branch and not from master/main.

So noted, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Redgifs] Some redgifs v3 links not working
2 participants
@reasonabledoubt @mikf