Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pixiv] use api for illust series #5983

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

mix5003
Copy link
Contributor

@mix5003 mix5003 commented Aug 10, 2024

i think this should fix can not download R-18 series in pixiv

for illust_series api i just guess url and lucky to find it.

mikf added a commit that referenced this pull request Aug 12, 2024
@mikf mikf merged commit b6a4021 into mikf:master Aug 12, 2024
9 checks passed
@mix5003
Copy link
Contributor Author

mix5003 commented Aug 12, 2024

@mikf i didn't realize_pagination.

if use _pagination should it remove offset from illust_series?

@mikf
Copy link
Owner

mikf commented Aug 12, 2024

No, it's fine the way it is.

Explaining some unorthodox method like

if key_data:
self.data = data.get(key_data)
key_data = None

to get illust_series_detail data into the paginated loop is far more work than just implementing it myself (at least for me), so I did just that.

for illust_series api i just guess url and lucky to find it.

Nice. Well done. And thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants