build: remove OpenGL::GL dependency for GL3 backends #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why still linking to OpenGL::GL even when using GLAD?
|
Hey, and thanks for the PR. And that's true, you have a point. For the GL3 backends we always use glad, we only use the system libraries for the GL2 backends. You can see from the CI checks that it this fails to build emscripten. That one does indeed need the |
|
I see. Should I write an if or make wasm a individual target? |
…L when using Emscripten.
|
Hi, I wanted some additional notes and changes here, so I added it directly to the PR, and also made Emscripten green. Thanks again for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why still linking to OpenGL::GL even when using GLAD?