Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FastBoot being imported when it is optional #190

Merged
merged 1 commit into from
Sep 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addon/authenticators/firebase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { getOwner } from '@ember/application';
import { inject as service } from '@ember/service';

import BaseAuthenticator from 'ember-simple-auth/authenticators/base';
import FastBootService from 'ember-cli-fastboot/services/fastboot';
import FirebaseService from 'ember-cloud-firestore-adapter/services/-firebase';
import firebase from 'firebase/compat/app';

Expand All @@ -14,7 +13,8 @@ export default class FirebaseAuthenticator extends BaseAuthenticator {
@service('-firebase')
private firebase!: FirebaseService;

private get fastboot(): FastBootService | null {
/* eslint-disable @typescript-eslint/no-explicit-any */
private get fastboot(): any {
return getOwner(this).lookup('service:fastboot');
}

Expand Down
4 changes: 2 additions & 2 deletions addon/session-stores/firebase.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { getOwner } from '@ember/application';
import classic from 'ember-classic-decorator';

import FastBootService from 'ember-cli-fastboot/services/fastboot';
import LocalStorageStore from 'ember-simple-auth/session-stores/local-storage';

@classic
export default class FirebaseStore extends LocalStorageStore {
private get fastboot(): FastBootService | null {
/* eslint-disable @typescript-eslint/no-explicit-any */
private get fastboot(): any {
return getOwner(this).lookup('service:fastboot');
}

Expand Down
33 changes: 0 additions & 33 deletions types/ember-cli-fastboot/services/fastboot.d.ts

This file was deleted.