Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: export AdapterRecordNotFoundError as default #306

Merged
merged 1 commit into from
May 31, 2024

Conversation

charlesfries
Copy link
Collaborator

@charlesfries charlesfries commented May 30, 2024

Fixes #305

This is a breaking change.

I opted to export AdapterRecordNotFoundError as default instead of modifying the generated re-export files in app . custom-errors only contains one export currently.

@charlesfries charlesfries merged commit 9375961 into master May 31, 2024
5 of 8 checks passed
@charlesfries charlesfries deleted the custom-errors-export branch May 31, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embroider app warns custom-errors has no default export
1 participant