Support for ids with multiple fields and '.' separated JSON nested fields #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use multiple field ids, concatenate all those field to form an id field ( comma separated after -id ). Also support for nested JSON '.' separated format.
Update index.go to support multi field ids
sakshambathla
changed the title
miku
requested changes
Jun 28, 2017
There was a problem hiding this comment.
Thanks a lot for this PR. Manually tested it and it works fine. There are some small issues with the code to sort out: Code needs to be formatted properly, usused (commented) code should be removed. In general, the logic for accessing nested values from a JSON document might be better implemented as a separate function.
indexing.go
Outdated
| idstr = t.String() | ||
| default: | ||
| return fmt.Errorf("cannot convert %T id value to string: %v", id, id) | ||
| var currrentId string |
indexing.go
Outdated
|
|
||
| idstring := options.IDField //A delimiter separates string with all the fields to be used as ID | ||
| id:=strings.FieldsFunc(idstring, func (r rune) bool { return r == ',' || r == ' '}) | ||
| // idtemp := strings.Split(idstring, ",") |
There was a problem hiding this comment.
Commented code is fine during development, but we should clean this up before the merge.
indexing.go
Outdated
| for counter:= range id{ | ||
| currrentId = id[counter] | ||
| tokstr := strings.Split(currrentId,".") | ||
| if len(tokstr)>1{ |
indexing.go
Outdated
| } | ||
|
|
||
| //enigma end |
Completed the requested changes
|
Completed the changes. Hope it is fine now. |
miku
approved these changes
Jun 29, 2017
|
Thanks a lot! I created a new release adding these changes: 0.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use multiple field ids, concatenate all those field to form an id field ( comma separated after -id ). Also support for nested JSON '.' separated format.
To make a new id field with concatenated fields, the command looks like:
esbulk -index index_name -type type_name -id field1,field2 -w 10 filename.ldj
Also, in case of nested JSON, a field name can be accessed like:
field1.subfield1.ssfield1
Example
esbulk -index index_name -type type_name -id field1,field2.subfield1.ssfield1 -w 10 filename.ldj