Adjust case of severity in Code Climate reporter (realm#5523)

mildm8nnered · Apr 7, 2024 · 745aec5 · 745aec5
1 parent dd8789b
commit 745aec5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,10 @@
   Rename SwiftLintBuildToolPlugin.
   Add Swift Package Manager installation instructions.  
   [garricn](https://github.com/garricn)
+
+* Fix Code Climate reporter output by having lower case severity
+  values to comply with the Code Climate specification.  
+  [waitButY](https://github.com/waitbutY)
 
 * The `superfluous_disable_command` rule will now be enabled for the `analyze`
   command, unless it has been disabled, and will warn about superfluous

diff --git a/Source/SwiftLintCore/Reporters/CodeClimateReporter.swift b/Source/SwiftLintCore/Reporters/CodeClimateReporter.swift
@@ -32,7 +32,7 @@ struct CodeClimateReporter: Reporter {
                     "end": violation.location.line ?? NSNull() as Any
                 ]
             ],
-            "severity": violation.severity == .error ? "MAJOR" : "MINOR",
+            "severity": violation.severity == .error ? "major" : "minor",
             "type": "issue"
         ]
     }

diff --git a/Tests/SwiftLintFrameworkTests/Resources/CannedCodeClimateReporterOutput.json b/Tests/SwiftLintFrameworkTests/Resources/CannedCodeClimateReporterOutput.json
@@ -11,7 +11,7 @@
       },
       "path" : "filename"
     },
-    "severity" : "MINOR",
+    "severity" : "minor",
     "type" : "issue"
   },
   {
@@ -26,7 +26,7 @@
       },
       "path" : "filename"
     },
-    "severity" : "MAJOR",
+    "severity" : "major",
     "type" : "issue"
   },
   {
@@ -41,7 +41,7 @@
       },
       "path" : "filename"
     },
-    "severity" : "MAJOR",
+    "severity" : "major",
     "type" : "issue"
   },
   {
@@ -56,7 +56,7 @@
       },
       "path" : null
     },
-    "severity" : "MAJOR",
+    "severity" : "major",
     "type" : "issue"
   }
 ]