-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: release should be created whenever merge to master happens #237
Comments
That is a fair observation, I'll try and employ more process in upcoming PRs
…On Tue, 7 Mar 2023, 10:07 am bonnyr, ***@***.***> wrote:
There is a confusing set of versions around this repository:
- the various git commits (latest one is e3c7276
<e3c7276>
a month ago)
- the actual releases on github - (
https://github.com/milesburton/Arduino-Temperature-Control-Library/releases/tag/3.9.1
released in 2020 ...)
- the version mentioned in (
https://github.com/milesburton/Arduino-Temperature-Control-Library/blob/master/library.properties
indicating the library version is 3.11 last updated last year)
Moreover, there is no single process for determining which version should
be used
I would suggest that a workflow be created that publishes a release once
the code is successfully built and tested (to the extent that it can be on
GitHub) and the various official release files be updated
(library.properies)
—
Reply to this email directly, view it on GitHub
<#237>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJGHM74KYRSGZAEXTSVRBTW24CFBANCNFSM6AAAAAAVSIGXCU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
did you want help with this? |
Any contributions are warmly welcomed, otherwise I'll take a look later
this week. The first step should be to normalize the versions that you
pointed out and cut a new release once fixed.
Probably makes the most sense to fix the problems addressed in this issue,
and do it all in one hit.
…On Tue, 7 Mar 2023 at 10:35, bonnyr ***@***.***> wrote:
did you want help with this?
—
Reply to this email directly, view it on GitHub
<#237 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJGHM7YO4ZT5HFTBR4SLN3W24FPTANCNFSM6AAAAAAVSIGXCU>
.
You are receiving this because you commented.Message ID:
<milesburton/Arduino-Temperature-Control-Library/issues/237/1457935005@
github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a confusing set of versions around this repository:
Moreover, there is no single process for determining which version should be used
I would suggest that a workflow be created that publishes a release once the code is successfully built and tested (to the extent that it can be on GitHub) and the various official release files be updated (library.properies)
The text was updated successfully, but these errors were encountered: