Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler isinstance() calls #111

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Simpler isinstance() calls #111

merged 1 commit into from
Sep 29, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

Supporting Python < 3.10 requires:

	isinstance(x, (A, B))

instead of:

	isinstance(x, A | B)

@DimitriPapadopoulos
Simpler isinstance() calls
c32ccb6 
Supporting Python < 3.10 requires:
	isinstance(x, (A, B))
instead of:
	isinstance(x, A | B)
milesgranger
milesgranger approved these changes Sep 29, 2023
View reviewed changes
Copy link
Owner

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@milesgranger milesgranger merged commit 58d46de into milesgranger:master Sep 29, 2023
56 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the isinstance branch September 29, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesgranger milesgranger milesgranger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @milesgranger