Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add underline to link #11

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Add underline to link #11

merged 2 commits into from
Oct 15, 2020

Conversation

weaversam8
Copy link
Contributor

This link is hardly visible

@weaversam8
Add underline to link
8e1237a 
This link is hardly visible
milesmcc
milesmcc requested changes Oct 15, 2020
View reviewed changes
Copy link
Owner

@milesmcc milesmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I do think the link isn't sufficiently visible, but I don't think this is the best solution. I think we should do something more general: mark the paragraph as being .content, so that the default link styling will apply.

@weaversam8 weaversam8 requested a review from milesmcc October 15, 2020 14:11
@milesmcc milesmcc merged commit caee558 into milesmcc:master Oct 15, 2020
@milesmcc
Copy link
Owner

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesmcc milesmcc Awaiting requested review from milesmcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weaversam8 @milesmcc