Change snippet url to display current host

[wvffle]

Closes #98

[JuniorJPDJ]

Is site.domain used anywhere beyond that?
It probably should be removed entirely from config.

[wvffle]

It is in a few other templates and in .po files, though @milesmcc, should I replace them?

[JuniorJPDJ]

I just searched for it and it will be hard to replace occurrences in e-mail templates.
IMO It would be cool to remove those which are on-page tho.

[JuniorJPDJ]

This is probably also must-have:

shynet/shynet/analytics/templates/analytics/scripts/page.js

Line 22 in 9d9d4a7

"{{protocol}}://{{request.site.domain|default:request.META.HTTP_HOST}}{{endpoint}}",

[wvffle]

hahahha, I did git commit -m "Remove `hostname` command" and it put my hostname :D

[JuniorJPDJ]

Are you sure that get_host will work in email templates?
In which context are those sent?

[wvffle]

request should be in the context: https://github.com/pennersr/django-allauth/blob/353386216b79f16709e97bb487c0bbbba2bc0c71/allauth/account/forms.py#L556

at least in theory. I do not have the opportunity to test emails.

[CasperVerswijvelt]

@wvffle You can test if email content is correct by checking shynet logs. Mails are also outputted there

[wvffle]

Works well.

[JuniorJPDJ]

Supercool then :D

[milesmcc]

Well done.

[Henridv]

@wvffle

How do I make sure the hostname is correct when running Shynet using Docker Compose?

When using the edge image from Docker Hub request.get_host seems to return 127.0.0.1.

For now I reverted back to using version 0.10.0.

[JuniorJPDJ]

You quacked up something badly. Are you accessing it using http://127.0.0.1?
It should just return host from client's request.

[Henridv]

No, I'm accessing it from a regular domain.

If I go to the Manage tab to get the script code it also says 127.0.0.1.

I'm running the container using docker compose, DNS is managed by Cloudflare and reverse proxy is nginx.

[JuniorJPDJ]

so this is probably misconfigured reverse proxy
try tcpdumping requests coming to shynet container

[CasperVerswijvelt]

@Henridv I'm also using Docker Compose, nginx as reverse proxy and cloudflare as DNS, and it works correctly for me.

This is my reverse proxy setup:

server {

        server_name analytics.casperverswijvelt.be;

        include /etc/nginx/snippets/listen-ssl-cloudflare.conf;
        include /etc/nginx/snippets/cloudflare-allow.conf;

        location / {
                proxy_pass http://localhost:9595;
                proxy_set_header Host $host;
                proxy_set_header X-Real-IP $remote_addr;
                proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
                proxy_set_header X-Forwarded-Proto $scheme;
                proxy_hide_header 'x-frame-options';
                add_header X-Frame-Options ALLOWALL;
        }
}

[Henridv]

Thanks @CasperVerswijvelt

This is the line I needed to add:

                proxy_set_header Host $host;

[milesmcc]

Great, glad this is fixed!