Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert source breaking change in TupleOps #1167

Merged
merged 1 commit into from
May 15, 2021

Conversation

joroKr21
Copy link
Collaborator

Users might be using TupleOps in a generic context where they have <: Product but not : IsTuple.
Propagating the bound might force downstream libraries to break binary compatibility which is not good.

Reverts #1132

@joroKr21 joroKr21 requested a review from milessabin May 15, 2021 09:12
@joroKr21 joroKr21 self-assigned this May 15, 2021
Copy link
Owner

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joroKr21 joroKr21 merged commit 5c59097 into milessabin:series/2.3 May 15, 2021
@joroKr21 joroKr21 deleted the tuple-ops branch May 15, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants