Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when using vim-dispatch #128

Closed
adambiggs opened this issue May 8, 2014 · 4 comments
Closed

Error when using vim-dispatch #128

adambiggs opened this issue May 8, 2014 · 4 comments
Labels
bug

Comments

@adambiggs
Copy link

With vim-dispatch support activated, files can't be opened from the quickfix list. It fails with the error

E21: Cannot make changes, 'modifiable' is off

I'm running Vim inside Tmux.
@kassio kassio closed this as completed in fda104e May 9, 2014
@kassio kassio added the bug label May 9, 2014
@adambiggs
Copy link
Author

I'm still experiencing this issue after your last commit... Happy to provide any debug info you might want.

@kassio kassio reopened this May 10, 2014
@kassio
Copy link
Contributor

kassio commented May 12, 2014

The errorformatwas wrong, could you try again please? But now if you want to use vim-dispatch you must set g:ack_use_dispatch.

@kassio
Copy link
Contributor

kassio commented May 12, 2014

fixed in last version

@kassio kassio closed this as completed May 12, 2014
@adambiggs
Copy link
Author

Happy to report that this bug is now fixed. Thanks @kassio!

AndrewRadev added a commit to AndrewRadev/ack.vim that referenced this issue Dec 24, 2014
@AndrewRadev
Merge branch 'master' of https://github.com/mileszs/ack.vim
758e112 
* 'master' of https://github.com/mileszs/ack.vim: (109 commits)
  Fix highlight, now using negative looking behind
  Change mappings o and O to behave as documented
  simplify regexp on highlight function
  Fix(again) highlight function to work with options
  Add a changelog entry
  Manual apply of @mannih fix in highlight
  fix highlight when using ack with options
  Fixed formatting of slashes
  Fix typo in the doc
  remove grouped results format
  fixes mileszs#129
  improve readme
  Fixes errorformat when using vim-dispatch.
  fixes mileszs#128. Always apply mappings, even when using vim-dispatch
  use &:lhlsearch instead of v:hlsearch, to keep compatibility
  fixes changelog
  Added vim-dispatch to changelog
  Remove comment
  Make Ack work with vim-dispatch
  add ack version on readme(fixes mileszs#125)
  ...

Conflicts:
	README.md
	doc/ack.txt
	plugin/ack.vim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kassio @adambiggs