Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ack opens quickfix also when no results found #225

Open
mboughaba opened this issue Oct 28, 2017 · 2 comments
Open

Ack opens quickfix also when no results found #225

mboughaba opened this issue Oct 28, 2017 · 2 comments
Labels
bug

Comments

@mboughaba
Copy link

Hi,

Ack always opens quickfix window even if no results are matched.
I reproduced this with Ag silver searcher as Ack command.
@ches ches added the bug label Nov 5, 2017
@ches
Copy link
Collaborator

ches commented Nov 5, 2017

You're right, and it seems :grep and :vimgrep avoid this so I'd call it an ack.vim bug.

Note that there isn't a good way I could find to avoid this happening when using vim-dispatch support, but it shouldn't happen with ordinary synchronous searches.

@ches
Copy link
Collaborator

ches commented Nov 5, 2017

Related: #167.

mboughaba added a commit to mboughaba/ack.vim that referenced this issue Dec 9, 2017
@mboughaba
Open qf or loc only when results found fixes (mileszs#225)
201ba55 
Ack opens quickfix also when no results found mileszs#225.
When not used with Dispatch, we check if location list or quick fix list were populated with valid results before opening them.
@mboughaba mboughaba mentioned this issue Dec 9, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ches @mboughaba