Live preview #135
Open
Live preview #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configurable using the g:ackpreview = 2 instead of g:ackpreview = 1
|
|
||
| let fname = pos.bufnr | ||
|
|
||
| if type(fname) == type(0) |
There was a problem hiding this comment.
As I see you do not need this three ifs, you can do just:
if fname == ''
return
else
let fname = bufname(fname)
endif
|
Sorry about the delay on review it. Thank's for the feature! ❤️ |
|
This is great feature! As I understand it prevent your active window from overwriting by the first matched file form quickfix list? |
|
@oluckyman It allows you to view where the match is in a scratch window as opposed to the main window. |
|
+1 This would be a great feature. |
|
+1 this would be great! |
|
Nothin? |
| execute "nnoremap <buffer> <silent> j j<CR><C-W><C-W>" | ||
| execute "nnoremap <buffer> <silent> k k<CR><C-W><C-W>" | ||
| elseif g:ackpreview == 2 | ||
| execute "nnoremap <buffer> <silent> j :call ack#preview()<CR>j" | ||
| execute "nnoremap <buffer> <silent> k :call ack#preview()<CR>k" |
There was a problem hiding this comment.
I think you were just copying the style above, but there's no need for execute on these four nnoremap lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I liked the preview ability but didn't like how it took over my main window. With this change, if you have
let g:ackpreview = 2, it will show it in a Preview window instead.