Async support #239
Open
Async support #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamFIREcracker
commented
Mar 5, 2018
| @@ -2,14 +2,6 @@ if exists('g:autoloaded_ack') || &cp | |||
| finish | |||
| endif | |||
|
|
|||
| if exists('g:ack_use_dispatch') | |||
| if g:ack_use_dispatch && !exists(':Dispatch') | |||
| call s:Warn('Dispatch not loaded! Falling back to g:ack_use_dispatch = 0.') | |||
There was a problem hiding this comment.
This was failing before as s:Warn was defined only at the end of the script, so I figured we could move this (and the additional check I added for async) inside s:Init()
|
Also subscribers of #187 might be interested in this. |
Use setloclist/setqflist not only to change the title, but also to append/replace entries in the quickfix/loclist. There was an issue earlier where entries in the quickfix/loclist windows sometimes ended up not being properly formatted (somehow errorformat was not properly picked up); this new solution should hopefully fix that.
This reverts commit f25deed.
Closed
The async ack implementation uses {c,l}addexpr and {c,l}getexpr to
populate the quickfix/location-list, which rely on global errorformat
vim/vim#569
|
Can confirm this works with neovim. Thanks for sharing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This PR adds a new
g:ack_use_asyncoption that once set will configure the plugin to search in the background by using Vim async job API; please note that it uses async.vim internally, so hopefully Neovim support will come for free.Subscribers of #209 might be interested in this.