Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Propshaft asset pipeline #1010

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Add support for Propshaft asset pipeline #1010

merged 1 commit into from
Apr 17, 2022

Conversation

serggl
Copy link
Contributor

@serggl serggl commented Feb 18, 2022

Purpose

This adds support to rails/propshaft asset pipeline introduced recently.

Solution

Basically it wraps Propshaft::Assets class and adds some methods to be compatible with existing Sprockets::Asset api

@tmaier
Copy link

tmaier commented Apr 13, 2022 •
edited

I tried it. I can confirm it works. Thanks!

It would be great to see this in the upstream branch...

unixmonkey
unixmonkey approved these changes Apr 17, 2022
View reviewed changes
Copy link
Collaborator

@unixmonkey unixmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unixmonkey unixmonkey merged commit 077f0b3 into mileszs:master Apr 17, 2022
@serggl serggl mentioned this pull request Jun 11, 2024
Open
@serggl serggl deleted the propshaft branch June 11, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unixmonkey unixmonkey unixmonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serggl @tmaier @unixmonkey