Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo of #possible_binary_locations #1025

Merged
merged 1 commit into from
May 19, 2022

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented May 19, 2022

This PR follows up on #816 - I think it's a simple typo.

Fixes #1022

Copy link
Collaborator

@unixmonkey unixmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly a typo, but originally it seems there was an assignment here, that didn't get carried over to the new file. This is the right fix, though.

Thank you!

@unixmonkey unixmonkey merged commit 8580e19 into mileszs:master May 19, 2022
@unixmonkey
Copy link
Collaborator

This is now published in version 2.6.3 of the gem. Thank you!

@olleolleolle olleolleolle deleted the patch-2 branch May 19, 2022 16:37
@olleolleolle
Copy link
Contributor Author

@unixmonkey That's swift! Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError (undefined local variable or method `possible_locations' for #<WickedPdf::Binary
2 participants