feat: Add :delete_temporary_files flag

[crespire]

Adds an option to keep the temporary files generated by pdf_from_string method. It defaults to using the close! handler in the ensure block.

[crespire]

For compatibility purposes, we might consider switching the option to delete_temp and adjusting the logic to match as that's the current default behaviour. Happy to do so, let me know!

[unixmonkey]

Yeah, I think I'd prefer the option to be delete_temporary_files: true, and check the value rather than key presence (someone might set it to something that evaluates to false), & use a conditional rather than send something more like this:

if options[:delete_temporary_files]
  file.close!
else
  file.close
end

What do you think?

[crespire]

Yeah, I think I'd prefer the option to be delete_temporary_files: true, and check the value rather than key presence (someone might set it to something that evaluates to false), & use a conditional rather than send something more like this:

if options[:delete_temporary_files]
  file.close!
else
  file.close
end

What do you think?

I think that's very sensible! I'll make the changes.

[unixmonkey]

Could you please add this new option to the README's list of "all options" please?

[crespire]

As an entry in this section? https://github.com/mileszs/wicked_pdf#super-advanced-usage

[unixmonkey]

I was thinking under this line here: https://github.com/mileszs/wicked_pdf/blob/master/README.md?plain=1#L262

[unixmonkey]

Great stuff! Thank you.

[unixmonkey]

This is now in version 2.7.0 of wicked_pdf. Thank you for your help!

[crespire]

This is now in version 2.7.0 of wicked_pdf. Thank you for your help!

Thank you for your guidance! Happy to have contributed.

[jjb]

Thanks for what seems to be a nice feature

maybe there could be more docs on when/why this is useful

without this, the temp files will be cleaned up during GC, right?

so it's useful maybe for someone creating pdfs at high volume, where the disk files might add up quickly?