Add WickedPdf.configure method #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieujobin
approved these changes
Jan 15, 2024
|
@kevinnio Please look into the rubocop/rspec failures please |
This methods uses the config block pattern to allow users to add config values without risking overwriting WickedPdf.config.
This adds a deprecation warning for the old way to set config. Users have the option to silence the warning if they want to do so.
kevinnio
force-pushed
the
kevinnio/add-config-block
branch
from
8754f4e
to
3b58fed
Compare
|
@mathieujobin Rubocop offenses have been fixed. |
|
@unixmonkey This is now ready for review/merging. |
|
@kevinnio Could you please update the |
|
@unixmonkey Done. |
|
@kevinnio Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
WickedPdf.configuremethod described in #1089. Also adds a deprecation warning forWickedPdf.config=which can be silenced.