Redo CI to remove individual gemfiles, Add Rails 7.1 and Ruby 3.3 #1108
+30
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testing with ruby 3.3, and truffleruby and rails 7.1
mathieujobin
commented
Mar 13, 2024
| @@ -4,39 +4,29 @@ on: [push, pull_request, workflow_dispatch] | |||
|
|
|||
| jobs: | |||
| tests: | |||
| name: Tests with Ruby ${{ matrix.ruby-version }} and Rails ${{ matrix.gemfile }} | |||
| name: CI Rails ${{ matrix.rails }} on ${{ matrix.ruby }} | |||
There was a problem hiding this comment.
I am making this shorter, so its easier to see the version on Actions details.
|
i used this pattern with apipie-rails and many other gems I maintain. please review and consider merging. |
|
@mileszs could take a look and consider merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1093