Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets helper Sprockets 4 compatibility fix. #615

Merged
merged 2 commits into from
Mar 13, 2017

Conversation

martinsabo
Copy link
Contributor

Pathname attr reader was removed/deprecated. Only filename is available in Sprockets 4.x.

Pathname attr reader was removed/deprecated. Only filename is available in Sprockets 4.x.
Use pathname for cases where filename is not available.
@rwrrll
Copy link

rwrrll commented Mar 13, 2017

I need this patch, but the Travis build appears to have failed because it couldn't find ARel 8.0. I've just checked & that gem is definitely live on Rubygems now, so is anyone able to retry this build?

@unixmonkey
Copy link
Collaborator

I just reran the Travis build and it failed exactly the same way.

Bundler could not find compatible versions for gem "arel":
  In Gemfile:
    rails was resolved to 5.1.0.alpha, which depends on
      activerecord (= 5.1.0.alpha) was resolved to 5.1.0.alpha, which depends on
        arel (~> 8.0)
Could not find gem 'arel (~> 8.0)', which is required by gem 'activerecord (=
5.1.0.alpha)', in any of the sources.
The command "eval bundle install --verbose " failed.

@unixmonkey unixmonkey merged commit bb631c8 into mileszs:master Mar 13, 2017
@unixmonkey
Copy link
Collaborator

Anyway, I like this change. It's going in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants