Fix NameError: uninitialized constant Mime::JS in Rails 5.1.0 beta #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ::Mime::JS is deprecated in Rails 5.0.x and removed in 5.1.0 beta. Instead of using ::Mime::JS, ::Mime[:js] is recommended. So I use this. * But in Rails 2.3, ::Mime[] is not defined and raise NoMethodError. So I check that ::Mime[] is defined using respond_to?, and if not defined, then use ::Mime::JS.
|
Sweet. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your nice gem.
I found Travis CI tests with Rails edge(5.1.0 beta) gemfile are failed by
NameError: uninitialized constant Mime::JS.In Rails 5.1.0 beta,
::Mime::JSand other constants are removed by this PR.I fixed this problem using
::Mime[:js].But in Rails 2.3,
::Mime[:js]cannot be used because::Mime.[]is not defined.So I checked
::Mime.[]is defined or not usingrespond_to?, and if::Mime.[]is not defined, then I use::Mime::JS.Please check my PR.
Thank you.