Adjust gemspec development dependencies #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to fix some merge conflicts, and since you authored this PR, the Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tests for local dev for the first time I ran into a few issues.
Firstly the bundler version in Ruby >= 2.5 was pegged to bundler >= 2. I don't think this necessary as I am happily continuing to use bundler v1.17.x for the moment and didn't want to be forced to upgrade. So I have relaxed the bundler version to use what is currently installed since there is no dependency on v2 in the core code.
Also added bootsnap since the dummy app requires it when booting.