Encapsulate option parsing #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves option parsing methods out of main class to improve clarity Cleanups up some private method testing and hackery in main class tests
|
@unixmonkey I think this PR is an easy non-breaking cleanup. |
|
Fixed up some merge conflicts, and ported over some changes from other PRs that have been merged since this was opened. Thanks for your contribution, and sorry for sitting on it so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves option parsing methods out of main class to improve clarity and refactoring options. Cleanups up some private method testing and hackery in main class tests also.