Remove code for unsupported rails and ruby versions #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because after_action is already present in rails 4 (minimum supported version), it is not necessary to check its existence
Prepend is available since ruby 2, which is < 2.2, and thus always available. The previous solution, while unbreaking some cases (mileszs#574), still breaks others like ViewComponent with rails < 6.1 (ViewComponent/view_component#288). Because there is no longer any need to support old versions of ruby, we can dispense with the alias method chain, and thus use a pure prepend solution, which fixes the problem in these known cases. We preserve the `render_with_wicked_pdf` method for backwards compatibility.
|
Thank you very much for this. I'm prepping for a Semver major release around dropping old Ruby & Rails versions, so it's time for this now. Sorry it took so long. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rails < 4 and ruby < 2.2 are unsupported, we can assume that
ActionController::Base.after_actionandModule.prependexist.This fixes ViewComponent/view_component#288 , and should fix #111 (but didn't test)