Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract reading and writing files in chunks #951

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Extract reading and writing files in chunks #951

merged 1 commit into from
Oct 31, 2020

Conversation

unixmonkey
Copy link
Collaborator

@unixmonkey unixmonkey commented Oct 31, 2020 •
edited
Loading

In #949 we made it so that files are written to and read from in chunks, which improves outcomes when creating large PDFs on memory-constrained system. This PR extracts this work into the WickedPdf::Tempfile class to clean up the main pdf_from_string and pdf_from_url methods.

@unixmonkey unixmonkey marked this pull request as ready for review October 31, 2020 19:00
@unixmonkey unixmonkey merged commit b56c46a into master Oct 31, 2020
@unixmonkey unixmonkey deleted the extract-chunk-io branch October 31, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@unixmonkey