Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check webpacker version #964

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

xronos-i-am
Copy link
Contributor

Webpacker's version check is failed if webpacker follows for wicked_pdf in Gemfile.

Webpacker is not defined at the gem initialization in the case.

require 'net/http'
# If webpacker is used, need to check for version
require 'webpacker/version' if defined?(Webpacker)

Webpacker::VERSION constant not defined unless 'webpacker/version' required. And webpacker_source_url(source) returns nil

def webpacker_source_url(source)
  return unless defined?(Webpacker) && defined?(Webpacker::VERSION)
  ...
end

@unixmonkey unixmonkey merged commit 2aea264 into mileszs:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants