Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the project compatible with .NET Core RC4 #141

Merged
merged 1 commit into from Feb 25, 2017
Merged

Make the project compatible with .NET Core RC4 #141

merged 1 commit into from Feb 25, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 25, 2017

I propose this merge request to support .NET Core with RC4 tooling.

Compared to pull request #122, the suggested modifications are very minor:

  • Only five lines had to be changed in the source code in order to comply with .NET Core APIs. These changes are retrocompatible with standard .NET Framework.
  • The dotnet core publish process is in a new directory PreMailer.Net-dotnet.

Install .NET Core SDK 1.0 rc4, execute nuget.bat inside PreMailer.Net-dotnet, and that should be it.

I stay available if you need any help.

This was referenced Feb 25, 2017
@martinnormark martinnormark merged commit b05fcd1 into milkshakesoftware:master Feb 25, 2017
@martinnormark
Copy link
Contributor

Thanks for this! 💪

Did you add PreMailer.Net-dotnet to avoid replacing existing nuspec?

@ghost
Copy link
Author

ghost commented Feb 26, 2017

Yep, I didn't want to mess with your scripts and project files so I didn't touch them at all.
But indeed, you can use the nuget.bat script inside PreMailer.Net-dotnet in replacement to the one in PreMailer.Net as the generated nuget package contains both assemblies (for standard .NET Framework and for .NET Core)

@ghost
Copy link
Author

ghost commented Feb 26, 2017

By the way, you can delete PreMailer.Net-dotnet/PreMailer.Net.nuspec, it's useless...

@cdroulers
Copy link

Could we get a nuget release with .NET Core support? It's been 23 days! I'm so excited about this project, I was afraid I had to use other tools than my razor templates for sending emails!

@martinnormark
Copy link
Contributor

@cdroulers v2 beta1 is on Nu Get as pre-release version: https://www.nuget.org/packages/PreMailer.Net/2.0.0-beta1

@cdroulers
Copy link

cdroulers commented Mar 21, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants