chore: working builds for Appveyor, use Node.js 8 and 10 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRuf
changed the title
added 2 commits
May 9, 2018 14:35
|
Related: nodejs/node#20325 |
|
Mh, I guess we can mark this as WIP until it is fixed in the dependencies and Node.js. |
|
Bump. |
|
@DanielRuf Good call! 🚀 |
cjpatoilo
reviewed
May 18, 2020
| } | ||
| }, | ||
| "resolutions": { | ||
| "natives": "1.1.3" |
There was a problem hiding this comment.
@DanielRuf please, help me to understand more about this. Could you explain better?
There was a problem hiding this comment.
This is for yarn to use the natives-version instead of a newer / older one as there is an issue with old Node versions like Node 8 - I think it was the compatibility / some crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to fix the failing Appveyor Windows builds.