fix: return empty slice if no values are found #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing pagination broke the empty values return. We now avoid returning empty slice values which are nil in Go and serialize as nulls in JSON. We also make sure we dont mess this up in the JS so if the null is returned we default to empty array. Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing pagination apparently broke the empty values return which return zero values for slices which are
nilwhich then deserialize tonull. This is ok, but we prefer to return empty size slices instead ofnull. They cost us nothing and are make it more obvious what's happening whencurling API.We also make sure we dont mess this up in the JS so if the
nullis returned in the future for whatever reason we default to an empty array when processing the API response.