enhance: Enable prefer node lables in resource group #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chyezh
reviewed
Oct 18, 2024
weiliu1031
force-pushed
the
enable_cross_az
branch
from
822a966
to
6ef46f9
Compare
|
/lgtm |
add prefer node labels in resource groups, so resource group will prefer to accept some node with given label. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
weiliu1031
force-pushed
the
enable_cross_az
branch
from
f06e714
to
b847e1b
Compare
congqixia
reviewed
Nov 4, 2024
resource group only need label set selector for now |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weiliu1031
added a commit
to weiliu1031/milvus-proto
that referenced
this pull request
Nov 11, 2024
* enhance: Enable prefer node lables in resource group add prefer node labels in resource groups, so resource group will prefer to accept some node with given label. Signed-off-by: Wei Liu <wei.liu@zilliz.com> * support node label format with key value pair Signed-off-by: Wei Liu <wei.liu@zilliz.com> * refine node label filter name Signed-off-by: Wei Liu <wei.liu@zilliz.com> --------- Signed-off-by: Wei Liu <wei.liu@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 11, 2024
* enhance: Enable prefer node lables in resource group add prefer node labels in resource groups, so resource group will prefer to accept some node with given label. * support node label format with key value pair * refine node label filter name --------- Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: milvus-io/milvus#36977
add prefer node labels in resource groups, so resource group will prefer to accept some node with given label.