Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize indexTypes and metricType for easy using #138

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

nameczz
Copy link
Collaborator

@nameczz nameczz commented Apr 18, 2023

image

Using IndexType and MetricType in our doc example, but it can't working because of wrong type. Fixed it for easy using.

Signed-off-by: nameczz <zizhao.chen@zilliz.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nameczz, shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #138 (601876a) into main (64a941b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 601876a differs from pull request most recent head 3563e90. Consider uploading reports for the commit 3563e90 to get more accurate results

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   99.39%   99.38%   -0.01%     
==========================================
  Files          22       22              
  Lines         985      983       -2     
  Branches      193      193              
==========================================
- Hits          979      977       -2     
  Misses          6        6              
Impacted Files Coverage Δ
milvus/const/Milvus.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shanghaikid shanghaikid merged commit 0bfdcb6 into main Apr 18, 2023
@shanghaikid shanghaikid deleted the optimize-types branch April 18, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants