Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support timeout as client param #148

Merged
merged 4 commits into from
Apr 24, 2023
Merged

support timeout as client param #148

merged 4 commits into from
Apr 24, 2023

Conversation

shanghaikid
Copy link
Contributor

const client = new MilvusClient({
    address: '192.168.0.1:19530',
    timeout:  '10s' // or 10*1000
});

Signed-off-by: shanghaikid <jiangruiyi@gmail.com>
Signed-off-by: shanghaikid <jiangruiyi@gmail.com>
Signed-off-by: shanghaikid <jiangruiyi@gmail.com>
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #148 (0e8a47d) into main (b9c3f93) will decrease coverage by 0.17%.
The diff coverage is 97.70%.

❗ Current head 0e8a47d differs from pull request most recent head 093ec46. Consider uploading reports for the commit 093ec46 to get more accurate results

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   99.80%   99.63%   -0.17%     
==========================================
  Files          22       22              
  Lines        1041     1108      +67     
  Branches      212      265      +53     
==========================================
+ Hits         1039     1104      +65     
- Misses          2        3       +1     
- Partials        0        1       +1     
Impacted Files Coverage Δ
milvus/BaseClient.ts 93.33% <66.66%> (-6.67%) ⬇️
milvus/Collection.ts 100.00% <100.00%> (ø)
milvus/Data.ts 99.14% <100.00%> (+0.03%) ⬆️
milvus/MilvusClient.ts 100.00% <100.00%> (ø)
milvus/MilvusIndex.ts 100.00% <100.00%> (ø)
milvus/Partition.ts 100.00% <100.00%> (ø)
milvus/Resource.ts 100.00% <100.00%> (ø)
utils/Format.ts 100.00% <100.00%> (ø)
utils/Function.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nameczz, shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: shanghaikid <jiangruiyi@gmail.com>
@shanghaikid shanghaikid merged commit 4c10776 into main Apr 24, 2023
@shanghaikid shanghaikid deleted the timeout branch April 24, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants