Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upsert failed on autoid enabled collection #402

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

shanghaikid
Copy link
Contributor

related to #399

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
@rakuzen25
Copy link

Hi @shanghaikid, thanks for the fix! Does this also fix the issue with $meta potentially being overwritten in buildDynamicRow?

@shanghaikid
Copy link
Contributor Author

Hi @shanghaikid, thanks for the fix! Does this also fix the issue with $meta potentially being overwritten in buildDynamicRow?

yes, it should fix this .

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (1750962) to head (2dbc2fb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          43       43           
  Lines        2913     2914    +1     
  Branches      720      721    +1     
=======================================
+ Hits         2835     2836    +1     
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanghaikid shanghaikid merged commit 99ef054 into main Dec 26, 2024
4 of 5 checks passed
@shanghaikid shanghaikid deleted the fix/enable-upsert-autoid branch December 27, 2024 01:52
shanghaikid added a commit that referenced this pull request Dec 27, 2024
Signed-off-by: ryjiang <jiangruiyi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants