Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Channel Write buffer is leaked in datanode since channel manager does not remove them during unwatch #35654

Closed
1 task done
congqixia opened this issue Aug 23, 2024 · 0 comments
Closed
1 task done

[Bug]: Channel Write buffer is leaked in datanode since channel manager does not remove them during unwatch #35654

congqixia opened this issue Aug 23, 2024 · 0 comments
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: ab532ae & 2.4.9
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Channel Write buffer is leaked in datanode since channel manager does not remove them during unwatch

Expected Behavior

Channel Write buffer & compaction executor shall perform cleanup when channel is unwatched from a datanode

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Aug 23, 2024
@congqixia congqixia self-assigned this Aug 23, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Aug 23, 2024
@congqixia
fix: Use correct release func when datanode unwatch a channel
f1a996c 
See also milvus-io#35654

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

o# Please enter the commit message for your changes. Lines starting
@congqixia congqixia mentioned this issue Aug 23, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Aug 23, 2024
@congqixia
fix: Use correct release func when datanode unwatch a channel
9420b2d 
See also milvus-io#35654

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Aug 23, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Aug 23, 2024
@congqixia
fix: Use correct release func when datanode unwatch a channel (#35655)
59387f0 
See also #35654

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Aug 23, 2024
@congqixia
fix: [2.4] Use correct release func when datanode unwatch a channel (#…
f3fb376 
…35657)

Cherry-pick from master
pr: #35655 
See also #35654

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia