Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [2.4] RBAC custom privilege group #37560

Merged
merged 2 commits into from
Nov 11, 2024

update proto

48c3a5d
Select commit
Loading
Failed to load commit list.
Merged

enhance: [2.4] RBAC custom privilege group #37560

update proto
48c3a5d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 11, 2024 in 1s

72.23% (target 77.00%)

View this Pull Request on Codecov

72.23% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 76.84347% with 179 lines in your changes missing coverage. Please review.

Project coverage is 72.23%. Comparing base (cedc340) to head (48c3a5d).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 75.00% 46 Missing and 16 partials ⚠️
internal/metastore/kv/rootcoord/kv_catalog.go 53.46% 35 Missing and 12 partials ⚠️
internal/rootcoord/meta_table.go 73.88% 31 Missing and 10 partials ⚠️
internal/proxy/impl.go 74.10% 21 Missing and 8 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37560      +/-   ##
==========================================
- Coverage   80.61%   72.23%   -8.39%     
==========================================
  Files        1069     1069              
  Lines      165966   166714     +748     
==========================================
- Hits       133794   120419   -13375     
- Misses      27812    41887   +14075     
- Partials     4360     4408      +48
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 91.31% <100.00%> (+0.32%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <ø> (ø)
internal/distributed/proxy/service.go 85.15% <100.00%> (+0.15%) ⬆️
internal/distributed/rootcoord/client/client.go 95.51% <100.00%> (+0.36%) ⬆️
internal/distributed/rootcoord/service.go 80.19% <100.00%> (+0.53%) ⬆️
internal/metastore/catalog.go 100.00% <ø> (ø)
...ernal/metastore/kv/rootcoord/rootcoord_constant.go 100.00% <100.00%> (ø)
internal/proxy/meta_cache.go 91.43% <100.00%> (+0.06%) ⬆️
internal/proxy/util.go 90.64% <ø> (-0.03%) ⬇️
internal/util/mock/grpc_rootcoord_client.go 86.99% <100.00%> (+6.12%) ⬆️
... and 7 more

... and 232 files with indirect coverage changes

View more details on Codecov