Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Iterator not handle OR expr operator correctly #2113

Closed
1 task done
MrPresent-Han opened this issue Jun 4, 2024 · 1 comment
Closed
1 task done

[Bug]: Iterator not handle OR expr operator correctly #2113

MrPresent-Han opened this issue Jun 4, 2024 · 1 comment
Labels
kind/bug Something isn't working
Milestone
2.4.4

Comments

@MrPresent-Han
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When expr has OR operator, like a>8 || b < 10, query iterator will wrongly handle the priority of operator because appending AND operator in the tail

Expected Behavior

related: milvus-io/milvus#33594

Steps/Code To Reproduce behavior

No response

Environment details

- Hardware/Softward conditions (OS, CPU, GPU, Memory):
- Method of installation (Docker, or from source):
- Milvus version (v0.3.1, or v0.4.0):
- Milvus configuration (Settings you made in `server_config.yaml`):

Anything else?

No response
@MrPresent-Han MrPresent-Han added the kind/bug Something isn't working label Jun 4, 2024
MrPresent-Han pushed a commit to MrPresent-Han/pymilvus that referenced this issue Jun 4, 2024
fix wrong expr handling due to and/or priorities(milvus-io#2113)
d923330 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
sre-ci-robot pushed a commit that referenced this issue Jun 4, 2024
@MrPresent-Han
fix: wrong expr handling due to and/or priorities(#2113) (#2114)
8b3b32e 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/pymilvus that referenced this issue Jun 4, 2024
fix wrong expr handling due to and/or priorities(milvus-io#2113)
01c1e39 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
sre-ci-robot pushed a commit that referenced this issue Jun 5, 2024
@MrPresent-Han
fix wrong expr handling due to and/or priorities(#2113) (#2115)
e48cd20 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
@XuanYang-cn XuanYang-cn added this to the 2.4.4 milestone Jun 11, 2024
@XuanYang-cn
Copy link
Contributor

seems fixex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
2.4.4
Development

No branches or pull requests
2 participants
@XuanYang-cn @MrPresent-Han