Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scipy dependency for sparse while still supporting scipy sparse matrix #2074

Merged

Conversation

zhengbuqian
Copy link
Collaborator

issue: #2067

@zhengbuqian
Copy link
Collaborator Author

will cherry pick to 2.4 after code review

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove scipy dependency in pyproject.toml too

@buqian-zilliz buqian-zilliz force-pushed the sparse-pymilvus-improvement branch from 6e6183d to 1c1f4a6 Compare May 8, 2024 08:45
@XuanYang-cn XuanYang-cn self-requested a review May 8, 2024 09:06
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@buqian-zilliz buqian-zilliz force-pushed the sparse-pymilvus-improvement branch from 1c1f4a6 to e30a0ac Compare May 8, 2024 09:13
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuanYang-cn, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f4d11e3 into milvus-io:master May 8, 2024
9 checks passed
@zhengbuqian zhengbuqian deleted the sparse-pymilvus-improvement branch May 8, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants