Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize vector data to a standard form during insertion (#27469) #2322

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

CaoHaiNam
Copy link
Contributor

This pull request handle Normalization function mentioned here milvus-io/milvus/#27469

Run: examples/example_normalization_fields.py to evaluate my pull request.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CaoHaiNam
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link

Welcome @CaoHaiNam! It looks like this is your first PR to milvus-io/pymilvus 🎉

@mergify mergify bot added the needs-dco label Nov 4, 2024
@CaoHaiNam CaoHaiNam force-pushed the milvus-27469-normalization branch from f77c27a to b580349 Compare November 4, 2024 17:29
@mergify mergify bot added dco-passed and removed needs-dco labels Nov 4, 2024
pymilvus/orm/collection.py Outdated Show resolved Hide resolved
pymilvus/orm/collection.py Outdated Show resolved Hide resolved
@CaoHaiNam
Copy link
Contributor Author

@XuanYang-cn @longjiquan @wangting0128
Due to an error on my part, I mistakenly pulled new code from the master branch and pushed it into this branch, which may complicate the review process. I apologize for any inconvenience this may cause.

For this PR, please focus on the following four files where I made changes:

examples/example_normalization_fields.py
pymilvus/client/utils.py
pymilvus/exceptions.py
pymilvus/orm/collection.py

Thank you for your understanding, and I appreciate your patience.

@XuanYang-cn
Copy link
Contributor

@CaoHaiNam This PR involved too many changes and commits from other PRs, please rebase you branch to the latest pymilvus master and narrow down to contain your changes only, THX

@XuanYang-cn
Copy link
Contributor

@XuanYang-cn @longjiquan @wangting0128 Due to an error on my part, I mistakenly pulled new code from the master branch and pushed it into this branch, which may complicate the review process. I apologize for any inconvenience this may cause.

For this PR, please focus on the following four files where I made changes:

examples/example_normalization_fields.py pymilvus/client/utils.py pymilvus/exceptions.py pymilvus/orm/collection.py

Thank you for your understanding, and I appreciate your patience.

I think a simple git rebase should fix the problem.

@CaoHaiNam
Copy link
Contributor Author

@XuanYang-cn @longjiquan @wangting0128 Due to an error on my part, I mistakenly pulled new code from the master branch and pushed it into this branch, which may complicate the review process. I apologize for any inconvenience this may cause.
For this PR, please focus on the following four files where I made changes:
examples/example_normalization_fields.py pymilvus/client/utils.py pymilvus/exceptions.py pymilvus/orm/collection.py
Thank you for your understanding, and I appreciate your patience.

I think a simple git rebase should fix the problem.

I got it, THX.

Signed-off-by: NamCaoHai <namch.hust@gmail.com>
Signed-off-by: NamCaoHai <namch.hust@gmail.com>
Signed-off-by: NamCaoHai <namch.hust@gmail.com>
Signed-off-by: NamCaoHai <namch.hust@gmail.com>
@CaoHaiNam CaoHaiNam force-pushed the milvus-27469-normalization branch from 6f8463d to 9517303 Compare November 8, 2024 07:17
Signed-off-by: NamCaoHai <namch.hust@gmail.com>
@CaoHaiNam
Copy link
Contributor Author

@XuanYang-cn I have finished the updates. Could you please review my pull request again? Thank you.

@CaoHaiNam
Copy link
Contributor Author

@XuanYang-cn Hi, just a quick follow-up on this pull request. I would appreciate any feedback or updates on the review status. Please let me know if there's anything I need to adjust. Thank you.

Signed-off-by: NamCaoHai <namch.hust@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants