Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db_name parameter at bulk_import #2446

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

counter2015
Copy link
Contributor

The purpose of this PR is to align the parameter passing in the Python SDK with the RESTful API, and to add the missing "dbName" field.

see: https://milvus.io/api-reference/restful/v2.4.x/v2/Import%20(v2)/Create.md

dbName
string
The name of the database that to which the collection belongs . Setting this to a non-existing database results in an error.

@sre-ci-robot
Copy link

Welcome @counter2015! It looks like this is your first PR to milvus-io/pymilvus 🎉

Signed-off-by: counter2015 <voidcounter@gmail.com>
@counter2015
Copy link
Contributor Author

/assign @longjiquan

@XuanYang-cn
Copy link
Contributor

/assign @yhmo
Please help review

@XuanYang-cn XuanYang-cn added the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label Dec 27, 2024
@yhmo
Copy link
Contributor

yhmo commented Dec 27, 2024

/lgtm

@XuanYang-cn
Copy link
Contributor

/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: counter2015, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn
Copy link
Contributor

related to: #2503

@sre-ci-robot sre-ci-robot merged commit 67a6cca into milvus-io:master Dec 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants