Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More effective job cancel check points #255

Closed
rompetroll opened this issue Sep 6, 2023 · 0 comments · Fixed by #257
Closed

More effective job cancel check points #255

rompetroll opened this issue Sep 6, 2023 · 0 comments · Fixed by #257
Labels
enhancement New feature or request

Comments

@rompetroll
Copy link
Contributor

Datahub users can stop running jobs using mim jobs operate -o kill <jobtitle>. When they do, a context is canceled, and there are a couple of places in the pipeline where datahub checks the context-cancel-state and aborts (kills) job processing.

In practise, these context check points are not frequent enough. Specifically jobs using MultiSource can spend alot of processing time processing source dependencies without checking for canceling.

Datahub should do cancel checks more frequently, so that users always can kill jobs in a timely manner

@rompetroll rompetroll added the enhancement New feature or request label Sep 6, 2023
rompetroll added a commit that referenced this issue Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant