Make job title required for job configs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rompetroll
approved these changes
Oct 26, 2022
| @@ -449,6 +449,9 @@ func (s *Scheduler) verify(jobConfiguration *JobConfiguration) error { | |||
| if len(jobConfiguration.Id) <= 0 { | |||
| return errors.New("job configuration needs an id") | |||
| } | |||
| if len(jobConfiguration.Title) <= 0 { | |||
| return errors.New("job configuration needs a title") | |||
There was a problem hiding this comment.
just a thought, maybe we should consider checking for duplicate titles as well. Not sure it this is the correct place - "addJob" is a good place to check for duplicates
There was a problem hiding this comment.
I agree. We currently do that in the deploy tool, but it would be nice to detect it here as well. Not everyone will use the deploy tool at all times, so we should just check it internally regardless. I'll have a look at it.
There was a problem hiding this comment.
@rompetroll I've added a check for unique title. Please have a look.
rompetroll
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged until all datahub configs have been migrated to use job title.
Fixes #165