Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for an ssh port #14

Merged
merged 1 commit into from
Jun 17, 2012
Merged

Added support for an ssh port #14

merged 1 commit into from
Jun 17, 2012

Conversation

chip
Copy link
Contributor

@chip chip commented Jun 16, 2012

Hi,

My server doesn't respond to port 22, so I needed to add support for the ssh port. Please feel free to merge this in if you feel there's a need for your users.

Thanks,
Chip

@mikong
Copy link
Member

mikong commented Jun 17, 2012

Hi Chip! There are 3 ways to handle this that I can think of. One is adding the ssh_port, as you have done. The second is doing it similar to rake-remote_task and have a ssh_flags to specify arbitrary ssh options. That way, we don't just support the port, but any other ssh option the user may need. Lastly, we can decide not to handle this in Mina, and make people handle this in their .ssh/config files.

Personally I think people should update their .ssh/config files instead. But this may be the wrong approach.

@rstacruz, what's your take on this?

Thanks!

@rstacruz
Copy link
Member

You can do this with set :ssh_options, '-p 22'.

Let's add :port on the next release.

Also, I think it's best that Mina not be opinionated about how users manage their own SSH config files.

@rstacruz
Copy link
Member

On an off-tangent, I'm also thinking of a convenience setting :uri where you can define user/domain/port/deploy_to using :uri, user@domain:22:/var/www/foo.com -- would be cool for multiple servers.

rstacruz added a commit that referenced this pull request Jun 17, 2012
Added support for an ssh port
@rstacruz rstacruz merged commit 2012717 into mina-deploy:master Jun 17, 2012
rstacruz added a commit that referenced this pull request Jun 17, 2012
rstacruz added a commit to mina-deploy/mina-docs that referenced this pull request Jun 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants