-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for a build step #178
Conversation
Add a ':build' step that can be executed after the deployment has been done and the code moved to its final destination but before the sysmlink for the current release has been updated (aka new code is live). This allows for build steps that require code to be in its final destination (i.e. some autoloaders resolve full paths, moving the code after the autoloader has done its setup work breaks the code).
+1 |
Will this work even if a build step isn't defined? |
Yes @rstacruz, if the build step is not defined, it works just like before. |
+1 |
I am not sure this extra step is really needed. You can always use $release_path in to :launch do block to get use the release path for your autoloaders to :launch do
queue "echo #{deploy_to}/$release_path"
end |
@d4be4st The issue is not with getting the value for the actual path. |
Conflicts: spec/commands/real_deploy_spec.rb
@d4be4st Any update on this? Any change you can merge this? |
Not true. It might be that current path is pointing to the newest path but you still did not restart your application, and that means the old code is still running on your application. But i will merge this as it seems like a good idea. |
Add a ':build' step that can be executed after the deployment has been
done and the code moved to its final destination but before the sysmlink
for the current release has been updated (aka new code is live).
This allows for build steps that require code to be in its final
destination (i.e. some autoloaders resolve full paths, moving the code
after the autoloader has done its setup work breaks the code).