Revert "fix tmp/restart.txt path" #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My bad, actually this works, you just need to create /tmp folder if it doesn't exists |
gabskoro
added a commit
that referenced
this pull request
Sep 7, 2014
Revert "fix tmp/restart.txt path"
|
Ah, ok maybe just document this in |
dvdhsu
added a commit
to dvdhsu/mina
that referenced
this pull request
Sep 15, 2014
In mina-deploy#225, gabskoro noted that the tmp folder might not exist in all Rails projects. So, touching restart.txt won't actually do anything. This creates the tmp directory, in case it doesn't exist, with mkdir -p. Unfortunately, there isn't a flag for touch which forces intermediate directory creation, we've got to use a separate command.
dvdhsu
added a commit
to dvdhsu/mina
that referenced
this pull request
Sep 15, 2014
In mina-deploy#225, gabskoro noted that the tmp folder might not exist in all Rails projects. So, touching restart.txt won't actually do anything. This creates the tmp directory, in case it doesn't exist, with mkdir -p. Unfortunately, there isn't a flag for touch which forces intermediate directory creation, so we've got to use a separate command.
|
I was using Mina yesterday, and the tmp directory didn't exist. So, I mkdir -p'd it. This is exactly what gabskoro was referring to. Looking at Github, it seems like this is a documented issue. So, I've fixed that, and created #229. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #208