Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for structure.sql for migration #57

Closed
wants to merge 1 commit into from
Closed

Conversation

sxua
Copy link

@sxua sxua commented Sep 23, 2012

When config.active_record.schema_format equals :sql, schema.rb is unchanged, while structure.sql is changing.

@rstacruz
Copy link
Member

Hmm, in the case that it's using the default schema.rb, wouldn't this show "Migrating database..." then after that "skipping migration"?

Thanks for the heads up, but I think the implementation may need a little work. :-)

@sxua
Copy link
Author

sxua commented Sep 24, 2012

Yeah, maybe there should be a variable in deploy.rb, like schema_format = :rb|:sql or extend check_for_changes_script to check more than one file?!

@rstacruz
Copy link
Member

I'd go with the latter.

@ghost ghost assigned rstacruz Dec 14, 2012
@rstacruz
Copy link
Member

Closing this in favor of a new issue.

@rstacruz rstacruz closed this Dec 14, 2012
chuckd added a commit to chuckd/mina that referenced this pull request Mar 31, 2014
This avoids the problems with schema_format :sql. Fixes mina-deploy#57, mina-deploy#59 and mina-deploy#74.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants