Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreman's stop task should stop #84

Merged
merged 1 commit into from
Jan 24, 2013
Merged

Conversation

andrewhr
Copy link
Contributor

Fix a copy & paste issue with the stop task. Apparently nobody ever stop deployed apps with mina :o)

Fix a copy & paste issue with the stop task. Apparently nobody ever stop deployed apps with mina :o)
@sosedoff
Copy link
Contributor

oops, my bad

rstacruz added a commit that referenced this pull request Jan 24, 2013
Foreman's stop task should stop
@rstacruz rstacruz merged commit 6939c3e into mina-deploy:master Jan 24, 2013
@rstacruz
Copy link
Member

Heh :) yay.

grigio added a commit to grigio/mina that referenced this pull request Jan 29, 2013
@grigio
Copy link

grigio commented Jan 29, 2013

I think that with Foreman "mina console" is broken because it doesn't load the env variables from .env
foreman run rails c

or more explicit
foreman run rails c -e .env

Don't you think a "mina foreman:console" could be useful?

@andrewhr
Copy link
Contributor Author

A foreman:console will be very nice, but will break mina's "recipes" modular nature. Maybe if we can 'decorate' commands in a universal way we could fix this issue. Something like:

  • bundler: bundle exec $command
  • foreman: foreman run $comand --env $environment

To generate bundle exec foreman run rails console --env .env.

@andrewhr andrewhr deleted the patch-1 branch January 29, 2013 19:21
@grigio
Copy link

grigio commented Jan 30, 2013

An alternative could be a mina foreman:console which could run on the server foreman run zsh (or bash) so you will have the full .env variables loaded an then you can run all your "rake *" tasks freely.
It will also be rails/ruby indipendent.

Another problem with foreman run xxxx -e .env is that if xxxx is something like rails -v (with arguments) is passed the command is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants